Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start implementation of quota exceeded check #7032

Merged
merged 2 commits into from
May 24, 2022
Merged

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented May 23, 2022

Description

Bugfix: Show message while upload size exceeds quota

We fixed a bug where an upload silently failed if the upload size exceeds the space quota. It now displays a detailed message instead
will be shown.

image

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented May 23, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

Results for oCISSharingBasic https://drone.owncloud.com/owncloud/web/25796/54/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIRestrictSharing-restrictSharing_feature-L49.png

webUIRestrictSharing-restrictSharing_feature-L49.png

webUISharingAcceptShares-acceptShares_feature-L110.png

webUISharingAcceptShares-acceptShares_feature-L110.png

webUISharingAcceptShares-acceptShares_feature-L179.png

webUISharingAcceptShares-acceptShares_feature-L179.png

webUISharingAcceptShares-acceptShares_feature-L85.png

webUISharingAcceptShares-acceptShares_feature-L85.png

webUISharingAcceptShares-acceptShares_feature-L99.png

webUISharingAcceptShares-acceptShares_feature-L99.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

@AlexAndBear AlexAndBear marked this pull request as ready for review May 24, 2022 09:00
@AlexAndBear AlexAndBear requested a review from fschade as a code owner May 24, 2022 09:00
Copy link
Collaborator

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor thing in the changelog item.

@pascalwengerter
Copy link
Contributor

@janackermann could you provide some feedback on owncloud/ocis#3767 (comment) whether the reva/ocis change is relevant for web still? Perhaps it isn't after this PR is merged but still valuable for other clients :)

…eeds-quota

Co-authored-by: Jannik Stehle <50302941+JammingBen@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented May 24, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

9.1% 9.1% Coverage
0.0% 0.0% Duplication

@AlexAndBear
Copy link
Contributor Author

@pascalwengerter I don't think it is relevant for web, as we are checking the quota on the personal drive as well, which will AFAIK shrink as the available disk size will

@AlexAndBear AlexAndBear merged commit 423d067 into master May 24, 2022
@delete-merged-branch delete-merged-branch bot deleted the issues/7025 branch May 24, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spaces: Show message, if upload exceeds Space Quota
4 participants