-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start implementation of quota exceeded check #7032
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Results for oCISSharingBasic https://drone.owncloud.com/owncloud/web/25796/54/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUIRestrictSharing-restrictSharing_feature-L49.pngwebUISharingAcceptShares-acceptShares_feature-L110.pngwebUISharingAcceptShares-acceptShares_feature-L179.pngwebUISharingAcceptShares-acceptShares_feature-L85.pngwebUISharingAcceptShares-acceptShares_feature-L99.png |
changelog/unreleased/bugfix-show-message-while-upload-size-exceeds-quota
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor thing in the changelog item.
changelog/unreleased/bugfix-show-message-while-upload-size-exceeds-quota
Outdated
Show resolved
Hide resolved
@janackermann could you provide some feedback on owncloud/ocis#3767 (comment) whether the reva/ocis change is relevant for web still? Perhaps it isn't after this PR is merged but still valuable for other clients :) |
…eeds-quota Co-authored-by: Jannik Stehle <50302941+JammingBen@users.noreply.github.com>
SonarCloud Quality Gate failed. |
@pascalwengerter I don't think it is relevant for web, as we are checking the quota on the personal drive as well, which will AFAIK shrink as the available disk size will |
Description
Bugfix: Show message while upload size exceeds quota
We fixed a bug where an upload silently failed if the upload size exceeds the space quota. It now displays a detailed message instead
will be shown.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: